[PATCH] Set VALUE_EXPR after a debug stmt is generated (PR sanitizer/81340).

Jakub Jelinek jakub@redhat.com
Fri Jul 28 11:19:00 GMT 2017


On Fri, Jul 28, 2017 at 01:11:51PM +0200, Martin Liška wrote:
> Hello.
> 
> Following patch fixed race where we first need to properly build
> all gimple_build_debug_bind (arg, var, NULL) and then DECL_HAS_VALUE_EXPR_P
> can be registered.
> 
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
> 
> Ready to be installed?
> Martin
> 
> gcc/ChangeLog:
> 
> 2017-07-10  Martin Liska  <mliska@suse.cz>
> 
> 	PR sanitizer/81340
> 	* sanopt.c (sanitize_rewrite_addressable_params):

Missing description of what you've changed.  Also, it isn't immediately
clear why this is needed.  For force_gimple* etc. I'd understand that
setting DECL_VALUE_EXPR prematurely will result in gimplification of that
into the DECL_VALUE_EXPR, but gimple_build_assign or gimple_build_debug_bind
shouldn't do that.  Or does the former invoke match.pd and that cares about
it?

	Jakub



More information about the Gcc-patches mailing list