[PATCH][PR 57371] Remove useless floating point casts in comparisons
Jeff Law
law@redhat.com
Fri Jul 7 16:57:00 GMT 2017
On 07/03/2017 12:59 PM, Marc Glisse wrote:
>> What happens if @0 is a floating point type? Based on the variable name
>> "itype" and passing TYPE_PRECISION (itype) to real_to_integer, it seems
>> like you're expecting @0 to be an integer. If so, you should verify
>> that it really is an integer type. Seems like a good thing to verify
>> with tests as well.
>
> @0 is the argument of a FLOAT_EXPR. verify_gimple_assign_unary
> guarantees that it is INTEGRAL_TYPE_P (or VECTOR_INTEGER_TYPE_P but then
> the result would have to be VECTOR_FLOAT_TYPE_P, and since it gets
> compared to REAL_CST... the test SCALAR_FLOAT_TYPE_P is actually
> redundant).
Duh. I should have realized that. My bad.
jeff
More information about the Gcc-patches
mailing list