[PATCH] Avoid implicitly declared __mpxrt_stop in libmpx
Alexander Ivchenko
mssakro@gmail.com
Mon Jan 30 11:22:00 GMT 2017
Hi Jakub,
Thanks for noticing that. Of course the declaration had to be in the
header for this case
Alexander
2017-01-30 13:13 GMT+03:00 Jakub Jelinek <jakub@redhat.com>:
> Hi!
>
> On Mon, Dec 26, 2016 at 06:15:01PM +0300, Alexander Ivchenko wrote:
>> Submitted as r243928.
>> >> (__mpxrt_stop): Ditto.
>
> I've noticed:
> ../../../../libmpx/mpxrt/mpxrt.c:255:6: warning: implicit declaration of function ‘__mpxrt_stop’; did you mean ‘__mpxrt_mode’? [-Wimplicit-function
> __mpxrt_stop ();
> ^~~~~~~~~~~~
> __mpxrt_mode
>
> The following patch fixes that warning, ok for trunk?
>
> 2017-01-30 Jakub Jelinek <jakub@redhat.com>
>
> * mpxrt/mpxrt-utils.h (__mpxrt_stop): New prototype.
>
> --- gcc/mpxrt/mpxrt-utils.h.jj 2016-12-27 15:35:06.000000000 +0100
> +++ gcc/mpxrt/mpxrt-utils.h 2017-01-30 10:31:51.502825561 +0100
> @@ -66,5 +66,6 @@ void __mpxrt_print (verbose_type vt, con
> mpx_rt_mode_t __mpxrt_mode (void);
> void __mpxrt_utils_free (void);
> void __mpxrt_print_summary (uint64_t num_brs, uint64_t l1_size);
> +void __mpxrt_stop (void) __attribute__ ((noreturn));
>
> #endif /* MPXRT_UTILS_H */
>
>
> Jakub
--
--Alexander
More information about the Gcc-patches
mailing list