[C++ PATCH] PR 79091, ICE with unnamed enum mangle

Nathan Sidwell nathan@acm.org
Wed Jan 18 13:00:00 GMT 2017


On 01/17/2017 03:17 PM, Jason Merrill wrote:

>> Hmm, what if write_exception_spec checks for a dependent
>> noexcept-specifier first, and noexcept_spec_p second?  That seems like
>> it would avoid needing any change to nothrow_spec_p.

that's a better solution.  However it was easier for it to check for the 
nothrow case, rather than call the helper function.  (It already checks 
for NULL spec or spec == noexcept_false_spec, so no additional loss of 
abstraction.)

Also committed the second patch to cleanup nothrow_spec_p itself, which 
I found overly confusing.

nathan
-- 
Nathan Sidwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mangle-79091.diff
Type: text/x-patch
Size: 2134 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20170118/8269a8cc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nothrow.diff
Type: text/x-patch
Size: 1708 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20170118/8269a8cc/attachment-0001.bin>


More information about the Gcc-patches mailing list