[PATCH, GCC/testsuite/ARM, ping] Fix empty_fiq_handler target selector

[Thomas Preudhomme]

Happy new year!

Ping?

Best regards,

Thomas

On 09/12/16 15:28, Thomas Preudhomme wrote:
> Hi,
>
> The current target selector for empty_fiq_handler.c testcase skips the test when
> targeting Thumb mode on a device with ARM execution state. Because it checks
> Thumb mode by looking for an -mthumb option it fails to work when GCC was
> configured with --with-mode=thumb. It is also too restrictive because interrupt
> handler can be compiled in Thumb-2. This patch checks the arm_thumb1 effective
> target instead of the -mthumb flag to fix both issues.
>
> ChangeLog entry is as follows:
>
>
> *** gcc/testsuite/ChangeLog ***
>
> 2016-12-09  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>
>         * gcc.target/arm/empty_fiq_handler: Skip instead if targeting Thumb-1
>         on a non Thumb-only target.
>
>
> Tested with GCC built for ARMv5T and ARMv7-A with --with-mode=thumb and
> --with-mode=arm and for ARMv6S-M with --with-mode=thumb:
>
> * test pass in all cases for ARMv5T and ARMv7-A with -marm
> * test pass in all cases for ARMv6S-M and ARMv7-A with -mthumb
> * test pass without option when defaulting to ARM for ARMv5T and ARMv7-A
> * test pass without option when defaulting to Thumb for ARMv6S-M and ARMv7-A
> * test is unsupported with -marm for ARMv5T
> * test is unsupported without option when defaulting to Thumb for ARMv5T
>
> Is this ok for stage3?
>
> Best regards,
>
> Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_empty_fiq_handler_testcase_selector.patch
Type: text/x-patch
Size: 592 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20170103/6107bbb4/attachment.bin>