[PATCH, GCC/testsuite/ARM, ping] Skip optional_mthumb tests if GCC has a default mode

[Thomas Preudhomme]

Ping?

Best regards,

Thomas

On 12/12/16 17:52, Thomas Preudhomme wrote:
> Hi,
>
> The logic to make -mthumb optional for Thumb-only devices is only executed when
> no -marm or -mthumb is given on the command-line. This includes configuring GCC
> with --with-mode= because this makes the option to be passed before any others.
> The optional_mthumb-* testcases are skipped when -marm or -mthumb is passed on
> the command line but not when GCC was configured with --with-mode. Not only are
> the tests meaningless in these configurations, they also spuriously FAIL if
> --with-mode=arm was used since the test are built for Thumb-only devices, as
> reported by Christophe Lyon in [1].
>
> [1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02082.html
>
> This patch adds logic to target-support.exp to check how was GCC configured and
> changes the optional_mthumb testcases to be skipped if there is a default mode
> (--with-mode=). It also fixes a couple of typo on the selectors.
>
> ChangeLog entry is as follows:
>
>
> *** gcc/testsuite/ChangeLog ***
>
> 2016-12-09  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>
>         * lib/target-supports.exp (check_configured_with): New procedure.
>         (check_effective_target_default_mode): new effective target.
>         * gcc.target/arm/optional_thumb-1.c: Skip if GCC was configured with a
>         default mode.  Fix dg-skip-if target selector syntax.
>         * gcc.target/arm/optional_thumb-2.c: Likewise.
>         * gcc.target/arm/optional_thumb-3.c: Fix dg-skip-if target selector
>         syntax.
>
>
> Is this ok for stage3?
>
> Best regards,
>
> Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: skip_optional_mthumb_test_default_mode.patch
Type: text/x-patch
Size: 3573 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20170103/03aa297a/attachment.bin>