[PATCH] avoid using %lli et al.

Martin Sebor msebor@gmail.com
Sun Dec 31 18:55:00 GMT 2017


Ping:

   https://gcc.gnu.org/ml/gcc-patches/2017-12/msg01399.html

On 12/20/2017 05:28 PM, Martin Sebor wrote:
> On 12/20/2017 05:07 PM, Richard Sandiford wrote:
>> Martin Sebor <msebor@gmail.com> writes:
>>> The attached patch replaces use of %lli and %llu with
>>> HOST_WIDE_INT_PRINT_DEC and HOST_WIDE_INT_PRINT_UNSIGNED
>>> for portability, and also replaces wide_int::to_shwi() with
>>> offset_int::from().
>>
>> Thanks for doing this.  I think you need to remove the (long long)
>> casts too though, so that the format stays in sync with the types.
>
> Doh!  Thanks!  Had I waited for stage 2 bootstrap I suspect I would
> have found out when it broke due to -Wformat complaining that
> HOST_WIDE_INT_PRINT_DEC (%ld on my system) not matching the long
> long argument.
>
> Attached is the patch with the casts removed (still bootstrapping).
>
> Martin



More information about the Gcc-patches mailing list