[PATCH][GRAPHITE] Fix PR71351

Tom de Vries Tom_deVries@mentor.com
Tue Dec 19 13:44:00 GMT 2017


On 12/19/2017 02:05 PM, Richard Biener wrote:
> On Tue, 19 Dec 2017, Tom de Vries wrote:
> 
>> On 09/21/2017 12:07 PM, Richard Biener wrote:
>>> -    exit_edge = create_empty_if_region_on_edge (entry_edge,
>>> -						unshare_expr (cond_expr));
>>
>> This removes the fix for PR70045:
>> ...
>> diff --git a/gcc/graphite-isl-ast-to-gimple.c
>> b/gcc/graphite-isl-ast-to-gimple.c
>> index 89a4118..8dd5dc8 100644
>> --- a/gcc/graphite-isl-ast-to-gimple.c
>> +++ b/gcc/graphite-isl-ast-to-gimple.c
>> @@ -821,7 +821,8 @@ graphite_create_new_loop_guard (edge entry_edge,
>>     if (integer_onep (cond_expr))
>>       exit_edge = entry_edge;
>>     else
>> -    exit_edge = create_empty_if_region_on_edge (entry_edge, cond_expr);
>> +    exit_edge = create_empty_if_region_on_edge (entry_edge,
>> +						unshare_expr (cond_expr));
>>
>>     return exit_edge;
>>   }
>> ...
>>
>>
>> Consequently, the pr70045.c testcase is currently ICE-ing.
> 
> Sorry.
> 

Np. Nice to see that the regression test caught it :)

>> Attached patch fixes this.
>>
>> OK for trunk if bootstrap and reg-test on x86_64 succeed?
> 
> Ok.

Thanks,
- Tom



More information about the Gcc-patches mailing list