[PATCH] Allow USE in PARALLELs in store_data_bypass_p

Jakub Jelinek jakub@redhat.com
Mon Dec 11 10:51:00 GMT 2017


On Mon, Dec 11, 2017 at 11:45:25AM +0100, Eric Botcazou wrote:
> > When looking at the rs6000_store_data_bypass_p stuff, I've noticed that
> > it accepts PARALLELs containing not just SETs and CLOBBERs like
> > store_data_bypass_p, but also USEs.  Given that it is something that
> > single_set also ignores, I think fixing store_data_bypass_p is the
> > right fix here.
> > 
> > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> > 
> > Note, the patch is larger due to the formatting fixes, the actual changes
> > are just 3x
> > -             if (GET_CODE (xxx) == CLOBBER)
> > +             if (GET_CODE (xxx) == CLOBBER || GET_CODE (xxx) == USE)
> 
> Couldn't the code be also re-factored?  Because 3x the same change is a lot...

Is that long enough to be worth it?  I mean, in all other places (rtlanal.c,
recog.c, ...) we use similar code in all spots where it is needed, adding
an inline would just mean yet another thing to remember.  Or do you mean
CLOBBER_OR_USE_P macro?  If so, we'd need to adjust all spots to use it, not
just these 3.

	Jakub



More information about the Gcc-patches mailing list