[PATCH] Validate that destination gcov file does not exist for, gcov-tool (PR gcov-profile/78783).

Nathan Sidwell nathan@acm.org
Fri Apr 14 13:17:00 GMT 2017


On 04/14/2017 08:45 AM, Martin Liška wrote:
> Hello.
>
> Patch handles ICE when gcov-tool either merges or scales gcov files and
> destination folder (where all files are merged) is non-empty.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
> And gcov.exp works on x86_64-linux-gnu.

Ok. Perhaps change the message from:
fatal_error (input_location, "Output file %s should be removed "
+		 "in destination folder: %s", filename, out);

to 'output file %s already exists in folder %s' or something?  I.e report what 
the problem is, not what the solution might be -- after all, if the only 
solution is to delete the output file, why isn't gcov-tool doing that?

nathan

-- 
Nathan Sidwell



More information about the Gcc-patches mailing list