Implement -Wimplicit-fallthrough (version 9)
Rainer Orth
ro@CeBiTec.Uni-Bielefeld.DE
Mon Sep 26 21:01:00 GMT 2016
Hi Marek,
> On Mon, Sep 26, 2016 at 03:34:40PM +0200, Rainer Orth wrote:
>> Hi Marek,
>>
>> > All right. I'll commit the patch on Monday.
>>
>> this patch caused quite some breakage: Ada, Solaris/x86 and SPARC don't
>> bootstrap any longer.
>
> Sorry about that. I had tested Ada + x86_64/ppc64/aarch64, but couldn't
> test neither Solaris nor SPARC.
the Solaris/x86 and SPARC issues were minor; I was just astonished to
see that so much didn't work on the Ada side.
>> The following patch allows i386-pc-solaris2.12 and sparc-sun-solaris2.12
>> bootstraps continue.
>>
>> Strangely, I needed to use gcc_fallthrough () in i386.c; a mere /* FALLTHRU */
>> had no effect.
>
> Yes, this is expected. /* FALLTHRU */ comments only work if the next token
> is a case label or default label.
Ok, that explains what's going on. I guess it would be good to make
this explicit in invoke.texi since someone else is guaranteed to stumble
across this as well.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
More information about the Gcc-patches
mailing list