[PATCH, 1/7] Move memory model declarations in memmodel.h
Thomas Preudhomme
thomas.preudhomme@foss.arm.com
Mon Sep 26 17:41:00 GMT 2016
On 26/09/16 11:53, Richard Biener wrote:
> On Mon, 26 Sep 2016, Thomas Preudhomme wrote:
>
>>
>>
>> On 26/09/16 10:15, Richard Biener wrote:
>>> On Thu, 22 Sep 2016, Thomas Preudhomme wrote:
>>>
>>>> Hi,
>>>>
>>>> This patch is part of a patch series to add support for ARMv8-M[1] to GCC.
>>>> This specific patch moves memory model declarations in memmodel.h.
>>>>
>>>> Currently, is_mm_* memory model related functions are declared in tree.h
>>>> which
>>>> prevents using them in constraints machine description files. This patch
>>>> move
>>>> this functions into a new memmodel.h header to allow such a thing and
>>>> update
>>>> all users of this function to include the new header.
>>>
>>> Ok. I wonder whether we can move the memmodel stuff from coretypes
>>> as well then?
>>
>> It's not needed for using what's in there in constraints.md but would be good
>> for consistency I think. Do you want me to add it to the patch or make a
>> separate one and commit this one?
>
> If it's trivial to include then go with this patch, if it requires work
> then as followup is fine with me.
I committed as is because emit-rtl.h uses enum memmodel so all files that
includes it must be updated. This gets worse because tm.h uses emit-rtl.h so all
target needs to be updated as well. The diff was becoming big so I decided to
keep it separate. I'll post the patch once it's complete and have gone through a
few bootstrap.
Best regards,
Thomas
More information about the Gcc-patches
mailing list