[PATCH v2] [RTEMS] Always use atomic builtins for libstdc++

Andreas Schwab schwab@suse.de
Mon Sep 26 09:15:00 GMT 2016


On Sep 22 2016, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:

> On 22 September 2016 11:11:42 CEST, Andreas Schwab <schwab@suse.de> wrote:
>>On Sep 22 2016, Sebastian Huber <sebastian.huber@embedded-brains.de>
>>wrote:
>>
>>> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
>>> index 6d897be..d7db435 100644
>>> --- a/libstdc++-v3/acinclude.m4
>>> +++ b/libstdc++-v3/acinclude.m4
>>> @@ -3490,9 +3490,10 @@ EOF
>>>    AC_LANG_RESTORE
>>>  
>>>    # Set atomicity_dir to builtins if all but the long long test
>>above passes.
>>> -  if test "$glibcxx_cv_atomic_bool" = yes \
>>> +  if { test "$glibcxx_cv_atomic_bool" = yes \
>>>       && test "$glibcxx_cv_atomic_short" = yes \
>>> -     && test "$glibcxx_cv_atomic_int" = yes; then
>>> +     && test "$glibcxx_cv_atomic_int" = yes } \
>>
>>You need a semicolon (or newline) before }.
>
> Please remind me why you need curly braces at all?

Shell operand precedence is non-intuitive.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Gcc-patches mailing list