Implement -Wimplicit-fallthrough (version 9)
Marek Polacek
polacek@redhat.com
Sat Sep 24 13:32:00 GMT 2016
On Fri, Sep 23, 2016 at 10:12:00PM +0000, Joseph Myers wrote:
> On Fri, 23 Sep 2016, Marek Polacek wrote:
>
> > On Fri, Sep 23, 2016 at 10:22:15AM -0400, Jason Merrill wrote:
> > > On Thu, Sep 22, 2016 at 9:59 AM, Marek Polacek <polacek@redhat.com> wrote:
> > > >> This is very close, thanks. Let's give a more helpful warning about
> > > >>
> > > >> [[fallthrough]] 0;
> > > >> __attribute__ ((fallthrough)) 0;
> > > >>
> > > >> both here and in cp_parser_statement, something like "fallthrough attribute
> > > >> not followed by ';'"
> > > >
> > > > Done. And I made similar tweaks in the C FE.
> > >
> > > The C++ changes are OK.
> >
> > Thanks very much!
> >
> > Now I'd like to ask for an approval of the ME parts.
> >
> > Also, Joseph said he had no comments, but since I've changed the C FE
> > parts a bit, I'd like to give him a chance to comment to perhaps look
> > at this again.
>
> I still have no comments on the C changes.
All right. I'll commit the patch on Monday.
Thanks all.
Marek
More information about the Gcc-patches
mailing list