[fw@deneb.enyo.de: [PATCH] ada/77535: GNAT.Perfect_Hash_Generators for non-1-based strings]
Thomas Quinot
quinot@adacore.com
Mon Sep 19 05:06:00 GMT 2016
> This patch fixes GNAT.Perfect_Hash_Generators for strings which are
> not 1-based. It does this by introducing its own storage type which
> fixes the first index as 1. This is also a minor optimization because
> it avoids the need to store the index.
>
> Okay for trunk?
>
> Should I try to construct a new test case for this? I don't see any
> existing tests for this package.
Florian,
Sorry for the delay in reviewing your patch. It looks good on the
surface; we're QAing it internally to make sure it does not break
PolyORB (which is the primary consumer of g-pehage). I'll let you know
as soon as I have the results from that run.
In any case it would be good to include a regression test for this
issue.
Thanks!
Thomas.
--
Thomas Quinot, Ph.D. ** quinot@adacore.com ** IT Lead Engineer
AdaCore -- Paris, France -- New York, USA
More information about the Gcc-patches
mailing list