[C PATCH] Tidy build_unary_op
Joseph Myers
joseph@codesourcery.com
Mon Sep 12 21:59:00 GMT 2016
On Sat, 10 Sep 2016, Marek Polacek wrote:
> A minor cleanup. First, FLAG is a really bad name for a parameter, and second,
> using two vars for the same thing is redundant (we never modify any of them).
> Also some bad formatting.
>
> Bootstrap/regtest on x86_64-linux running. Ok for trunk?
OK. If changing this argument it would seem natural to make it a bool
(and update callers to use true/false), unless that would be confusing for
other reasons (e.g. passing it through to other functions where the
corresponding argument isn't boolean).
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Gcc-patches
mailing list