[PING] Re: [PATCH, i386] Fix some warnings/errors that appear when enabling -Wnarrowing when building gcc

[Uros Bizjak]

On Tue, Sep 6, 2016 at 8:06 PM, Eric Gallager <egall@gwmail.gwu.edu> wrote:
> On 9/6/16, Uros Bizjak <ubizjak@gmail.com> wrote:
>> On Tue, Sep 6, 2016 at 5:33 PM, Eric Gallager <egall@gwmail.gwu.edu> wrote:
>>> Ping? CC-ing an i386 maintainer since the patch mostly touches
>>> i386-specific files. Also, to clarify, I say "warnings/errors" because
>>> they start off as warnings in stage 1 but then become errors in stage
>>> 2. Note also that my patch leaves out the part where I modify the
>>> configure script to enable -Wnarrowing, because the rest of the code
>>> isn't quite ready for that yet.
>>
>> You are probably referring to [1]? It looks OK, modulo:
>>
>> +DEF_TUNE (X86_TUNE_QIMODE_MATH, "qimode_math", ~(0U))
>>
>> where parenthesis are not needed.
>>
>>
>> Please resubmit the patch with a ChangeLog entry, as instructed in [2]
>>
>> [1] https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02129.html
>> [2] https://gcc.gnu.org/contribute.html#patches
>>
>> Uros.
>>
>
>
> Okay, reattached. Here's a ChangeLog entry to put in gcc/ChangeLog:
>
> 2016-09-06  Eric Gallager  <egall@gwmail.gwu.edu>
>
>         * config/i386/i386.c: Add 'U' suffix to constants to avoid
>         -Wnarrowing.
>         * config/i386/x86-tune.def: Likewise.
>         * opts.c: Likewise.
>
>
> (Please also note that I don't have commit access.)

Thanks, committed with slightly adjusted ChangeLog:

2016-09-07  Eric Gallager  <egall@gwmail.gwu.edu>

    * config/i386/i386.c: Add 'U' suffix to processor feature bits
    to avoid -Wnarrowing warning.
    * config/i386/x86-tune.def: Likewise for DEF_TUNE selector bitmasks.
    * opts.c: Likewise for SANITIZER_OPT bitmasks.

Uros.