[PATCH][AARCH64]Skip gcc.target/aarch64/pr66912.c in tiny or large memory model.

Andrew Pinski pinskia@gmail.com
Thu Oct 27 15:29:00 GMT 2016


On Thu, Oct 27, 2016 at 4:24 AM, Renlin Li <renlin.li@foss.arm.com> wrote:
> Hi,
>
> On 27/10/16 11:48, Szabolcs Nagy wrote:
>>
>> On 27/10/16 11:25, Renlin Li wrote:
>>>
>>> Hi all,
>>>
>>> This a simple patch to fix gcc.target/aarch64/pr66912.c.
>>> It's a test case only applicable to small memory model which is the
>>> default
>>> one.
>>>
>>
>>    /* { dg-final { scan-assembler ":got(page_lo15)?:n_common" } } */
>>
>> i think this is supposed to work on tiny and small model as well.
>> (:got:var vs :gotpage_lo15:var)
>>
> Sorry, I didn't aware it's a regex which will match both.
>
>> it will have to be updated for large model when we have support for that.
>
>
> yes, large memory model will have different relocation for this case, which
> will
> not be caught by this pattern.


It also fails for ILP32.  I have not looked into the assembler output there yet.

Thanks,
Andrew

>
> Regards,
> Renlin
>
>
>>
>>> It has been tested to run only when the memory model is small.
>>> Okay to commit?
>>>
>>> Regards,
>>> Renlin Li
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2016-10-27  Renlin Li  <renlin.li@arm.com>
>>>
>>>      * gcc.target/aarch64/pr66912.c: Skip tiny and large memory model.
>>
>>
>



More information about the Gcc-patches mailing list