[PATCHv2 2/7, GCC, ARM, V8M] Handling ARMv8-M Security Extension's cmse_nonsecure_entry attribute

Kyrill Tkachov kyrylo.tkachov@foss.arm.com
Thu Oct 27 10:19:00 GMT 2016


On 27/10/16 10:54, Andre Vieira (lists) wrote:
> On 26/10/16 17:28, Kyrill Tkachov wrote:
>> On 26/10/16 17:28, Andre Vieira (lists) wrote:
>>> On 26/10/16 10:33, Kyrill Tkachov wrote:
>>>> +static tree
>>>> +arm_handle_cmse_nonsecure_entry (tree *node, tree name,
>>>> +                 tree /* args */,
>>>> +                 int /* flags */,
>>>> +                 bool *no_add_attrs)
>>>> +{
>>>> +  tree fndecl;
>>>> +
>>>> +  if (!use_cmse)
>>>> +    {
>>>> +      *no_add_attrs = true;
>>>> +      return NULL_TREE;
>>>> +    }
>>>>
>>>> Do you also want to warn the user here that the attribute will be
>>>> ignored?
>>>> This looks ok to me otherwise.
>>>>
>>> Can easily do and might be more user friendly. How about
>>> "<attribute_name> attribute ignored without -mcmse option."
>> Yes, that's fine (without the full stop at the end)
>> Kyrill
>>
>>> Cheers,
>>> Andre
>>>
> Hi,
>
> Reworked comments. No change to ChangeLogs.

Ok.
Thanks,
Kyrill

> Cheers,
> Andre



More information about the Gcc-patches mailing list