PING: new pass to warn on questionable uses of alloca() and VLAs

Aldy Hernandez aldyh@redhat.com
Wed Oct 19 13:27:00 GMT 2016


On 10/19/2016 09:24 AM, Eric Botcazou wrote:
>> It seems to me that there is a precedence for -W type tests to start
>> with a capital letter, as opposed to a lowercase letter:
>>
>> $ cd gcc.dg
>> $ ls W[a-z]* |wc
>>      280     280    5816
>>
>> Do you think it would perhaps be reasonable to rename all of them to
>> uppercase?
>
> Yes, I agree that this would be more consistent.
>
>> You could take -Wvla-[1-7].c and I can take the subsequent ones?
>
> Not sure if this wouldn't make us tread on each other's toe. ;-)  I'd just
> rename your 3 new testcases (-Wvla-larger-than-1.c, Wvla-larger-than-2.c and
> Walloca-11.c probably) and promote the existing wvla-[1-7].c to uppercase.
>

It's unclear from your response whether you want to do this or want me 
to do it.  In the interest of being lazy, I'll let you do it :).

Aldy

p.s. If OTOH, you want me to do it, let me know.



More information about the Gcc-patches mailing list