[PING #2] [PATCH] fix outstanding -Wformat-length failures (pr77735 et al.)

Martin Sebor msebor@gmail.com
Mon Oct 17 16:39:00 GMT 2016


I'm still looking for a review of the patch below:

   https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00043.html

>
> The patch should clean up the remaining test suite failures on
> ILP32 targets and also fixes up some remaining issues in the
> gimple-ssa-sprintf pass that stand in the way of re-enabling
> the printf-return-value optimization.
>
> I'm traveling next week so I'm hoping to enable the optimization
> shortly after this patch goes in so that if there's any fallout
> from it I can fix it before I leave.
>
> Thanks
> Martin
>
> On 10/02/2016 02:10 PM, Martin Sebor wrote:
>> The attached patch fixes a number of outstanding test failures
>> and ILP32-related bugs in the gimple-ssa-sprintf pattch pointed
>> out in bug 77676 and 77735).  The patch also fixes c_strlen to
>> correctly handle wide strings (previously it accepted them but
>> treated them as nul-terminated byte sequences), and adjusts the
>> handling of "%a" to avoid assuming a specific number of decimal
>> digits (this is likely a defect in C11 that I'm pursuing with
>> WG14).
>>
>> Tested on powerpc64le, i386, and x86_64.
>>
>> There is one outstanding failure in the builtin-sprintf-warn-1.c
>> test on powerpc64le that looks like it might be due to the
>> printf_pointer_format target hook not having been set up entirely
>> correctly.  I'll look into that separately, along with pr77819.
>>
>> Martin
>



More information about the Gcc-patches mailing list