[PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)

Jakub Jelinek jakub@redhat.com
Fri Oct 14 09:38:00 GMT 2016

On Fri, Oct 14, 2016 at 11:05:22AM +0200, Bernd Schmidt wrote:
> On 10/13/2016 12:27 PM, Bernd Schmidt wrote:
> >On 10/13/2016 12:20 PM, Jakub Jelinek wrote:
> >
> >>both relied on TREE_PUBLIC be actually false for LABEL_DECLs, because
> >>otherwise they have code later on that can't handle LABE_DECLs (plus
> >>callers
> >>also not expecting LABEL_DECLs might not bind locally or might not
> >>bind to
> >>the current def.
> >
> >Ok, thanks. Guess I'll be testing the following:
> >
> The change below bootstrapped and tested ok on x86_64-linux. Ok to commit?

Perhaps gcc_checking_assert would be enough, but if you prefer gcc_assert,
it is ok too.

> 	* varasm.c (default_binds_local_p): Assert we don't have LABEL_DECLs.
> 	(decl_binds_to_current_def_p): Likewise.


More information about the Gcc-patches mailing list