Questionable code in gcov-io.c
Jakub Jelinek
jakub@redhat.com
Wed Oct 12 12:54:00 GMT 2016
On Wed, Oct 12, 2016 at 02:23:36PM +0200, Bernd Schmidt wrote:
> >It seems that lines 198 and 200 do the same thing, at line 200 we know that
> >mode == 0, so we just assign 1. Should we just remove the condition on line 197?
>
> The intention seems to be that a negative gcov_var.mode means we're writing,
> so for a size zero file maybe that's the expected result. But of course none
> of the existing code is going to expect that.
>
> There are more oddities here...
Unfortunately I really don't remember, and it seems we don't have the
posting in gcc-patches archive at all.
Found it in http://marc.info/?l=gcc-patches&m=107747608611324 though.
Jakub
More information about the Gcc-patches
mailing list