[PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

Jakub Jelinek jakub@redhat.com
Wed Oct 12 10:54:00 GMT 2016


On Wed, Oct 12, 2016 at 12:36:29PM +0200, Markus Trippelsdorf wrote:
> Here are some examples:
> 
>  /* Don't break */
>  /* drop through */      //very popular
>  /* fall though */ 
>  /* pass through... */
>  /* break intentionally omitted */ 
>  /* fallthough */
>  /* Don't break, this is a failed frame! */
>  /* leave break out intentionly */ 
>  /* else: Fall trough */  
>  /* passthrough */ 
>  /* NOBREAK */
>  /* follow thru */ 
>  /* go through here */ 

It would be nice to see all those 136 comments, perhaps sort | uniq -c
merged together.
Letting people fix fall though or fallthough or Fall trough misspellings
is a good thing.  And for the others, I think the comment adjustment won't
take more than a few seconds each, compared to having to analyze the 900+
cases.

	Jakub



More information about the Gcc-patches mailing list