PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math
Fritz Reese
fritzoreese@gmail.com
Tue Oct 11 11:26:00 GMT 2016
On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
...
> There are a few small clean-up that can be
> done. For example,
>
> +static gfc_expr *
> +get_radians (gfc_expr *deg)
> +{
> + mpfr_t tmp;
...
> the tmp variable is unneeded in the above. Converting the double
> precision 180.0 to mpfr_t and then dividing is probably slower
> than just dividing by 180.
>
> + /* Set factor = pi / 180. */
> + factor = gfc_get_constant_expr (deg->ts.type, deg->ts.kind, °->where);
> + mpfr_const_pi (factor->value.real, GFC_RND_MODE);
> + mpfr_div_ui (factor->value.real, factor->value.real, 180, GFC_RND_MODE);
>
...
Good catch, fixed and committed r240989. Many thanks to you and Jerry.
---
Fritz Reese
More information about the Gcc-patches
mailing list