[PATCH/AARCH64] Have the verbose cost model output output be controllable

Kyrill Tkachov kyrylo.tkachov@foss.arm.com
Fri Oct 7 08:01:00 GMT 2016


Hi Andrew,

On 24/09/16 06:46, Andrew Pinski wrote:
> Hi,
>    As reported in PR 61367, the aarch64 back-end is too verbose when it
> is dealing with the cost model.  I tend to agree, no other back-end is
> this verbose.  So I decided to add an option to enable this verbose
> output if requested.
>
> I did NOT document it in invoke.texi because I don't feel like this is
> an option which an user should use.  But I can add it if requested.
>
> OK?  Bootstrapped and tested on aarch64-linux-gnu with no regressions.
>
> Thanks,
> Andrew Pinski
>
> ChangeLog:
> * config/aarch64/aarch64.opt (mverbose-cost-dump): New option.
> * config/aarch64/aarch64.c (aarch64_rtx_costs): Use
> flag_aarch64_verbose_cost instead of checking for details dump.
> (aarch64_rtx_costs_wrapper): Likewise.

I'm okay with the idea, but I can't approve (cc'ing people who can).
One nit:

+mverbose-cost-dump
+Common Var(flag_aarch64_verbose_cost)
+Enables verbose cost model dummping in the debug dump files.

You should add "Undocumented" to that.
I don't think the option is major enough to warrant an entry in invoke.texi.
It's only for aarch64 backend developers who know exactly what they're looking for.

Cheers,
Kyrill




More information about the Gcc-patches mailing list