[PATCH, RS6000] improve builtin expansion of memcmp for p7

Segher Boessenkool segher@kernel.crashing.org
Thu Oct 6 21:40:00 GMT 2016


Hi Aaron,

On Thu, Oct 06, 2016 at 04:12:31PM -0500, Aaron Sawdey wrote:
> I've improved the builtin memcmp expansion so it avoids a couple of 
> things that p7 and previous processors don't like. Performance on
> p7 is now never worse than glibc memcmp(). Bootstrap/regtest in progress
> on power7 ppc64 BE. 
> 
> OK for trunk if testing passes?

Okay, thanks.  Just a few formatting nits...


> 2016-10-06  Aaron Sawdey  <acsawdey@linux.vnet.ibm.com>
> 
> 	* config/rs6000/rs6000.h (TARGET_EFFICIENT_OVERLAPPING_UNALIGNED)

Needs a colon at the end of line here.

> 	Add macro to say we can efficiently handle overlapping unaligned
> 	loads.


> @@ -18736,13 +18744,18 @@
>    while (bytes > 0)
>      {
>        int align = compute_current_alignment (base_align, offset);
> -      load_mode = select_block_compare_mode(offset, bytes, align, word_mode_ok);
> +      if (TARGET_EFFICIENT_OVERLAPPING_UNALIGNED)
> +	load_mode = select_block_compare_mode(offset, bytes, align,
> +					      word_mode_ok);

Space before paren.

Thanks,


Segher



More information about the Gcc-patches mailing list