RFC: A few more fallthrus

Jason Merrill jason@redhat.com
Wed Oct 5 19:47:00 GMT 2016


One of these was a bug, though it doesn't affect regression testing.
-------------- next part --------------
commit c49bb7df1d286456f2e5738c05ea56e6816a7475
Author: Jason Merrill <jason@redhat.com>
Date:   Wed Oct 5 11:32:33 2016 -0400

    * parser.c (cp_parser_skip_to_end_of_statement): Add missing break.

diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index 8c5cb20..0914ae2 100644
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -2544,7 +2544,6 @@ add_builtin_candidate (struct z_candidate **candidates, enum tree_code code,
 	  type2 = ptrdiff_type_node;
 	  break;
 	}
-      /* XXX Really fallthru?  */
       /* FALLTHRU */
     case MULT_EXPR:
     case TRUNC_DIV_EXPR:
diff --git a/gcc/cp/cxx-pretty-print.c b/gcc/cp/cxx-pretty-print.c
index f4d2a2e..a290c87 100644
--- a/gcc/cp/cxx-pretty-print.c
+++ b/gcc/cp/cxx-pretty-print.c
@@ -142,7 +142,6 @@ pp_cxx_unqualified_id (cxx_pretty_printer *pp, tree t)
 
     case OVERLOAD:
       t = OVL_CURRENT (t);
-      /* XXX Really fallthru?  */
       /* FALLTHRU */
     case VAR_DECL:
     case PARM_DECL:
diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c
index f3dc359..60bbf49 100644
--- a/gcc/cp/parser.c
+++ b/gcc/cp/parser.c
@@ -3495,8 +3495,7 @@ cp_parser_skip_to_end_of_statement (cp_parser* parser)
 	      cp_lexer_consume_token (parser->lexer);
 	      return;
 	    }
-	  /* XXX Really fallthru?  */
-	  /* FALLTHRU */
+	  break;
 
 	case CPP_OPEN_BRACE:
 	  ++nesting_depth;
@@ -27932,7 +27931,6 @@ cp_parser_cache_defarg (cp_parser *parser, bool nsdmi)
 	      parser->in_template_argument_list_p = saved_italp;
 	      break;
 	    }
-	  /* XXX Really fallthru?  */
 	  /* FALLTHRU */
 	case CPP_CLOSE_PAREN:
 	case CPP_ELLIPSIS:


More information about the Gcc-patches mailing list