[PATCH] Fix fallout of PR77399 fix

Uros Bizjak ubizjak@gmail.com
Tue Oct 4 10:56:00 GMT 2016


On Tue, Oct 4, 2016 at 12:25 PM, Richard Biener <rguenther@suse.de> wrote:
> On Tue, 4 Oct 2016, Uros Bizjak wrote:
>
>> On Tue, Oct 4, 2016 at 12:00 PM, Richard Biener <rguenther@suse.de> wrote:
>>
>> >> x86 targets should always be in pair, so "target i?86-*-* x86_64-*-*",
>> >> with an optional ia32 target addition when the test is valid for 32
>> >> bit targets only, or { ! ia32 } addition when test is valid for 64-bit
>> >> targets only.
>> >
>> > I need SSE2 support but didn't want to adjust dg-options with another
>> > { target } ... so with default ISA this is valid for x86_64 only
>> > AFAIK?  It might be ok for i?86-*-* with -m64 thus that is your
>> > { i?86-*-* x86_64-*-* } && { ! ia32 } then?  But x86_64-*-* -m32
>> > is ok ...
>> >
>> > I'll try a
>> >
>> > /* { dg-options "-O -fdump-tree-cddce1 -msse2" { target { i?86-*-*
>> > x86_64-*-* } } } */
>> >
>> > then.
>>
>> You need sse2_runtime effective target. Please see e.g.
>> gcc.dg/pr37544.c (or gcc.dg/pr36584.c for 32-bit only target) on how
>> it should be used
>
> It's a dg-do compile testcase only so I think that's not needed.

In this case, you are right.

BTW: You can use dg-additional-options in your patch.

Uros.



More information about the Gcc-patches mailing list