[PATCH] Fix -Wimplicit-fallthrough -C, handle some more comment styles and comments in between FALLTHRU comment and label

Tom Tromey tom@tromey.com
Mon Oct 3 14:35:00 GMT 2016


>>>>> "Eric" == Eric Botcazou <ebotcazou@adacore.com> writes:

Eric> So, because of its excessive pickiness, the warning ends up making the user 
Eric> butcher informative comments.  How is that helpful?

Those comments are not informative.  In most cases I kept the original
text just to forestall complaints.  But really if you read those
comments they are pointless.

That said, it would be better by far to have a mode where only the
attribute is accepted, and where comments aren't parsed.  Then gcc could
also warn when the attribute is used incorrectly.  The reason this is
preferable is that it helps protect against more errors, say those
introduced by merge mistakes.

Tom



More information about the Gcc-patches mailing list