[Fortran, Patch, pr77663, v1] libgfortran/caf/single.c: three minor problems and a lost token

Andre Vehreschild vehre@gmx.de
Sat Oct 1 14:01:00 GMT 2016


Hi Paul,

thanks for the fast review. Committed as r240695.

Regards,
	Andre

On Sat, 1 Oct 2016 14:42:35 +0200
Paul Richard Thomas <paul.richard.thomas@gmail.com> wrote:

> Hi Andre,
> 
> It looks fine to me - OK for trunk.
> 
> Thanks for the patch
> 
> Paul
> 
> On 1 October 2016 at 13:30, Andre Vehreschild <vehre@gmx.de> wrote:
> > Hi all,
> >
> > attached patch fixes some issue in caf/single.c that were reported as pure
> > style issues, but uncovered at least one significant error when handling
> > sending data to a remote image when the memory and associated token was not
> > allocated yet. The send_by_ref-routine stored the new token only on the
> > stack when the component to allocate was scalar which lead to crashes, when
> > that token was later on accessed. Furthermore was the memory and the token
> > lost. This patch fixes the issue.
> >
> > Bootstraps and regtests ok on x86_64-linux/F23. Ok for trunk?
> >
> > Regards,
> >         Andre
> > --
> > Andre Vehreschild * Email: vehre ad gmx dot de  
> 
> 
> 


-- 
Andre Vehreschild * Email: vehre ad gmx dot de 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: submit.diff
Type: text/x-patch
Size: 4566 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20161001/8430461c/attachment.bin>


More information about the Gcc-patches mailing list