[PATCH] Fix PR78306
Jeff Law
law@redhat.com
Tue Nov 29 16:52:00 GMT 2016
On 11/29/2016 12:47 AM, Richard Biener wrote:
>> Balaji added this check explicitly. There should be tests in the testsuite
>> (spawnee_inline, spawner_inline) which exercise that code.
>
> Yes he did, but no, nothing in the testsuite.
I believe the tests are:
c-c++-common/cilk-plus/CK/spawnee_inline.c
c-c++-common/cilk-plus/CK/spawner_inline.c
But as I mentioned, they don't check for proper behaviour
>
> There is _nowhere_ documented _why_ the checks were added. Why is
> inlining a transform that can do anything bad to a function using
> cilk_spawn?
I know, it's disappointing. Even the tests mentioned above don't shed
any real light on the issue.
Jeff
More information about the Gcc-patches
mailing list