[PATCH,testsuite] MIPS: Upgrade to MIPS IV if using (HAS_MOVN) with MIPS III.

Toma Tabacu Toma.Tabacu@imgtec.com
Wed Nov 9 17:18:00 GMT 2016


> From: Moore, Catherine [mailto:Catherine_Moore@mentor.com]
> Sent: 08 November 2016 20:47
> To: Toma Tabacu; gcc-patches@gcc.gnu.org
> Cc: Matthew Fortune
> Subject: RE: [PATCH,testsuite] MIPS: Upgrade to MIPS IV if using (HAS_MOVN)
> with MIPS III.
> 
> 
> 
> > -----Original Message-----
> > From: Toma Tabacu [mailto:Toma.Tabacu@imgtec.com]
> > Sent: Monday, November 7, 2016 11:21 AM
> > gcc/testsuite/ChangeLog:
> >
> > 2016-11-07  Toma Tabacu  <toma.tabacu@imgtec.com>
> >
> > 	* gcc.target/mips/mips.exp (mips-dg-options): Upgrade to MIPS IV if
> using
> > 	(HAS_MOVN) with MIPS III.
> >
> > diff --git a/gcc/testsuite/gcc.target/mips/mips.exp
> > b/gcc/testsuite/gcc.target/mips/mips.exp
> > index 39f44ff..e22d782 100644
> > --- a/gcc/testsuite/gcc.target/mips/mips.exp
> > +++ b/gcc/testsuite/gcc.target/mips/mips.exp
> > @@ -1129,7 +1129,7 @@ proc mips-dg-options { args } {
> >          # We need MIPS IV or higher for:
> >  	#
> >  	#
> > -	} elseif { $isa < 3
> > +	} elseif { $isa < 4
> >  		   && [mips_have_test_option_p options "HAS_MOVN"] }
> > {
> >  	    mips_make_test_option options "-mips4"
> >          # We need MIPS III or higher for:
> 
> Hi Toma,
> 
> The patch itself is OK, but the ChangeLog entry line length is greater than 80.
> 

Yes, sorry. The version below fixes this.

> Do you have write access to the repository?  Please let me know if you would
> like me to commit this for you?
> 
> Thanks,
> Catherine

No, I don't have write access.
I would be grateful if you could commit the patch for me, if you think it
would be OK with Matthew.
To be clear, I am not in a rush to get this committed.

Thanks,
Toma Tabacu

gcc/testsuite/ChangeLog:

2016-11-09  Toma Tabacu  <toma.tabacu@imgtec.com>

	* gcc.target/mips/mips.exp (mips-dg-options): Upgrade to MIPS IV if
	using (HAS_MOVN) with MIPS III.

diff --git a/gcc/testsuite/gcc.target/mips/mips.exp b/gcc/testsuite/gcc.target/mips/mips.exp
index 39f44ff..e22d782 100644
--- a/gcc/testsuite/gcc.target/mips/mips.exp
+++ b/gcc/testsuite/gcc.target/mips/mips.exp
@@ -1129,7 +1129,7 @@ proc mips-dg-options { args } {
         # We need MIPS IV or higher for:
 	#
 	#
-	} elseif { $isa < 3
+	} elseif { $isa < 4
 		   && [mips_have_test_option_p options "HAS_MOVN"] } {
 	    mips_make_test_option options "-mips4"
         # We need MIPS III or higher for:



More information about the Gcc-patches mailing list