[PATCH] Clean up tests where a later dg-do completely overrides another.

[Mike Stump]

On May 18, 2016, at 2:59 PM, Jeff Law <law@redhat.com> wrote:
> 
> On 05/02/2016 10:24 AM, Dominik Vogt wrote:
>> On Mon, May 02, 2016 at 09:29:50AM -0600, Jeff Law wrote:
>>> On 04/29/2016 05:56 PM, Dominik Vogt wrote:
>>>> ...
>>>> Maybe a comment should be added to the test case
>>>> 
>>>> /* If this test is *run* (not just compiled) and therefore fails
>>>>    on non sh*-targets, this is because of a bug older DejaGnu
>>>>    versions.  This is fixed with DejaGnu-1.6.  */
>>> I think we have a couple issues now that are resolved if we step
>>> forward to a newer version of dejagnu.
>>> 
>>> Given dejagnu-1.6 was recently released, should we just bite the
>>> bullet and ask everyone to step forward?

We can recommend 1.6...  Just I don't see the value in going out of our way to make pre-1.6 versions behave worse then they always have for existing test cases.  If people want to add a new test case that will in effect require 1.6 to behave nicely, that's fine, just don't break 99% of the existing test cases.

> FWIW, Fedora 24 uses dejagnu-1.6.  Not sure about other distributions.

Ubuntu 16.04:

$ runtest --version
Expect version is       5.45
Tcl version is          8.6
Framework version is    1.5.3