[Patch ARM/AArch64 06/11] Add missing vtst_p8 and vtstq_p8 tests.

[Kyrill Tkachov]

Hi Christophe,

On 19/05/16 12:54, Christophe Lyon wrote:
> On 13 May 2016 at 16:47, James Greenhalgh <james.greenhalgh@arm.com> wrote:
>> On Fri, May 13, 2016 at 04:41:33PM +0200, Christophe Lyon wrote:
>>> On 13 May 2016 at 16:37, James Greenhalgh <james.greenhalgh@arm.com> wrote:
>>>> On Wed, May 11, 2016 at 03:23:56PM +0200, Christophe Lyon wrote:
>>>>> 2016-05-02  Christophe Lyon  <christophe.lyon@linaro.org>
>>>>>
>>>>>        * gcc.target/aarch64/advsimd-intrinsics/vtst.c: Add tests
>>>>>        for vtst_p8 and vtstq_p8.
>>>> And vtst_p16 and vtstq_p16 too please.
>>>>
>>>> vtst_s64
>>>> vtstq_s64
>>>> vtst_u64
>>>> vtstq_u64 are also missing (AArch64 only).
>>>>
>>> vtst_p16/vtstq_p16 are AArch64 only too, right?
>> Not in my copy of:
>>
>>    http://infocenter.arm.com/help/topic/com.arm.doc.ihi0073a/IHI0073A_arm_neon_intrinsics_ref.pdf
>>
>> I see it is missing from config/arm/arm_neon.h so that's a bug in the GCC
>> implementation. It should be easy to resolve, map it to the same place
>> as vtst_u16 and vtst_s16 - this is just a bit operation which takes no
>> semantics from the data-type.
>>
> Maybe you have a way of automatically checking that the doc and arm_neon.h
> contents match? I mean:
> - are there other intrinsics documented, but not defined in arm_neon.h ?
> - are there intrinsics in arm_neon.h, but not in the doc?
>
>> Would you mind spinning the fix for that and committing it before this
>> patch?
>>
> I've attached an updated patch which contains the definition for the
> missing vtst_p16 and vtstq_p16,
> as well as tests for vtst_p8, vtstq_p8, vtst_p16 and vtstq_p16.

The patch is ok (I'm assuming the newly added tests pass ;)

Thanks,
Kyrill

>>> My introduction message was not clear enough: this series
>>> only attempts to fully cover AArch32 intrinsics.
>> Understood, sorry for the extra noise.
>>
> Coverage of AArch64 intrinsics will require another effort :)
>
>> Thanks,
>> James
>>
>>