[PATCH] Fix spec-options.c test case

Bernd Schmidt bschmidt@redhat.com
Mon May 2 10:26:00 GMT 2016


On 05/01/2016 09:52 AM, Bernd Edlinger wrote:
> Hi,
>
> I took a closer look at this test case, and I found, except that
> it triggers a dejagnu bug, it is also wrong.  I have tested with
> a cross-compiler for target=sh-elf and found that the test case
> actually FAILs because the foo.specs uses "cppruntime" which
> is only referenced in gcc/config/sh/superh.h, but sh/superh.h
> is only included for target sh*-superh-elf, see gcc/config.gcc.
>
> This means that it can only pass for target=sh-superh-elf.
>
> The attached patch fixes the testcase and makes it run always,
> so that it does no longer triggers the dejagnu bug.

So, two things. Why not use a string in the specs file that exists on 
all targets? If it's a sh-specific thing we want to test, move why not 
move it to gcc.target?


Bernd



More information about the Gcc-patches mailing list