AW: [PATCH] Add a new target hook to compute the frame layout

Jeff Law law@redhat.com
Wed Jun 22 18:34:00 GMT 2016


On 06/22/2016 01:20 AM, Bernd Edlinger wrote:
> On 06/21/16 23:29, Jeff Law wrote:
>>
>> How does this macro interact with INITIAL_FRAME_POINTER_OFFSET?
>
> That I forgot to mention:  INITIAL_FRAME_POINTER_OFFSET is just
> a single call, so whenever it is called from lra/reload the frame layout
> is really expected to change, and so it does not make a difference if the target
> computes the frame layout in TARGET_COMPUTE_FRAME_LAYOUT or in
> INITIAL_FRAME_POINTER_OFFSET.
>
> But I do not know of any targets that still use INITIAL_FRAME_POINTER_OFFSET,
> and maybe support for this target hook could be discontinued as a follow-up patch.
INITIAL_FRAME_POINTER_OFFSET is only defined in 4 ports:

./ft32/ft32.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0
./m32r/m32r.h:#define INITIAL_FRAME_POINTER_OFFSET(VAR) \
./moxie/moxie.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0
./vax/vax.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0;

However, the m32r version is actually #if 0'd out.  So it's really only 
defined in 3 ports and always to "0".  So yea, it'd be a good candidate 
to collapse away.

Jeff



More information about the Gcc-patches mailing list