[PATCH]Fix scan-tree-dump-times syntax errors in gcc.dg/tree-ssa/attr-hotcold-2.c
Renlin Li
renlin.li@foss.arm.com
Mon Jun 20 14:07:00 GMT 2016
Hi,
This is a simple patch to fix the syntax errors in dg-final directive
lines within this test case.
According to the documentation, the syntax of this directive should be:
'''scan-tree-dump-times regex num suffix [{ target/xfail selector }]'''
Now the test case compilers Okay in arm environment. However, the last
two checks seem failing. This is another issue.
Okay to commit?
Regards,
Renlin
gcc/testsuite/ChangeLog:
2016-06-20 Renlin Li <renlin.li@arm.com>
* gcc.dg/tree-ssa/attr-hotcold-2.c: Fix syntax errors.
On 13/06/16 17:35, Kyrill Tkachov wrote:
> Hi Honza,
>
> On 07/06/16 20:27, Jan Hubicka wrote:
>> Hello,
>> Maritn Liska measured branch predictor hitrates on current tree and
>
> In the testsuite I'm seeing:
> ERROR: gcc.dg/tree-ssa/attr-hotcold-2.c: error executing dg-final:
> syntax error in target selector "profile_estimate"
>
> on aarch64-none-elf.
> I think the hunk:
> -/* { dg-final { scan-ipa-dump-times "block 4, loop depth 0, count 0,
> freq 1\[^0-9\]" 1 "profile_estimate" } } */
> +/* { dg-final { scan-tree-dump-times 1 "hot label heuristics" 1
> "profile_estimate" } } */
> +/* { dg-final { scan-tree-dump-times 1 "cold label heuristics" 1
> "profile_estimate" } } */
> +/* { dg-final { scan-tree-dump-times "block 4, loop depth 0, count 0,
> freq \[1-4\]\[^0-9\]" 1 "profile_estimate" } } */
>
> is buggy, should it be
> -/* { dg-final { scan-ipa-dump-times "block 4, loop depth 0, count 0,
> freq 1\[^0-9\]" 1 "profile_estimate" } } */
> +/* { dg-final { scan-tree-dump-times "hot label heuristics" 1
> "profile_estimate" } } */
> +/* { dg-final { scan-tree-dump-times "cold label heuristics" 1
> "profile_estimate" } } */
> +/* { dg-final { scan-tree-dump-times "block 4, loop depth 0, count 0,
> freq \[1-4\]\[^0-9\]" 1 "profile_estimate" } } */
> ?
>
> With that change the test runs but still FAILs:
> FAIL: gcc.dg/tree-ssa/attr-hotcold-2.c scan-tree-dump-times
> profile_estimate "block 4, loop depth 0, count 0, freq [1-4][^0-9]" 1
> FAIL: gcc.dg/tree-ssa/attr-hotcold-2.c scan-tree-dump-times
> profile_estimate "block 5, loop depth 0, count 0, freq
> [6-9][0-9][0-9][0-9]" 1
>
> Thanks,
> Kyrill
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-patch
Size: 853 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20160620/575f3905/attachment.bin>
More information about the Gcc-patches
mailing list