[patch, avr] Fix PR67353

Pitchumani Sivanupandi pitchumani.sivanupandi@atmel.com
Wed Jun 15 10:17:00 GMT 2016


On Mon, 2016-06-13 at 17:48 +0200, Georg-Johann Lay wrote:
> Pitchumani Sivanupandi schrieb:
> > 
> > $ avr-gcc test.c -Wno-misspelled-isr
> > $
> What about -Werror=misspelled-isr?

Updated patch.

> > 
> > diff --git a/gcc/config/avr/avr.c b/gcc/config/avr/avr.c
> > index ba5cd91..587bdbc 100644
> > --- a/gcc/config/avr/avr.c
> > +++ b/gcc/config/avr/avr.c
> > @@ -753,7 +753,7 @@ avr_set_current_function (tree decl)
> >           that the name of the function is "__vector_NN" so as to
> > catch
> >           when the user misspells the vector name.  */
> >  
> > -      if (!STR_PREFIX_P (name, "__vector"))
> > +      if ((!STR_PREFIX_P (name, "__vector")) &&
> > (avr_warn_misspelled_isr))
> >          warning_at (loc, 0, "%qs appears to be a misspelled %s
> > handler",
> If, instead of the "0" the respective OPT_... enum is used in the
> call 
> to warning_at, the -Werror= should work as expected (and explicit
> "&& 
> avr_warn_misspelled_isr" no more needed).

Ok. Updated patch as per the comments.

If OK, could someone commit please?

Regards,
Pitchumani
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr67353.patch
Type: text/x-patch
Size: 2563 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20160615/98f4a1cb/attachment.bin>


More information about the Gcc-patches mailing list