[Committed] S/390: Fix MAX_ARGS value.

Jakub Jelinek jakub@redhat.com
Mon Jun 13 09:01:00 GMT 2016


On Mon, Jun 13, 2016 at 10:51:16AM +0200, Andreas Krebbel wrote:
> On 06/13/2016 10:43 AM, Jakub Jelinek wrote:
> > On Mon, Jun 13, 2016 at 10:38:22AM +0200, Andreas Krebbel wrote:
> >> Committed to GCC 5 and mainline branches.
> > 
> > What about gcc-6-branch?  It also has MAX_ARGS 5, and case for arity 6.
> 
> Done.

Also, it isn't clear to me, are there any s390 builtins right now that
actually have 6 arguments (my reading is that you don't count the return
value into that)?  I.e. beyond the bootstrap issues, is the change actually
fixing expansion of any builtins (there is if (arity >= MAX_ARGS) check),
or is the arity 6 case there just for potential further builtins?
My confusion comes from s390-builtin*.def using e.g. DEF_FN_TYPE_6
which looks to me like actually 5 argument builtin type where the first type
is the return type.  Wouldn't e.g. gcc/builtin-types.def call it
DEF_FUNCTION_TYPE_5 (rather than _6)?
Also, where is e.g. __builtin_s390_vstrcbs (as randomly chosen builtin
using DEF_FN_TYPE_6) covered in the testsuite?

	Jakub



More information about the Gcc-patches mailing list