[PATCH] Improve optimize pragma/attribute diagnostics

Richard Biener rguenther@suse.de
Wed Jun 8 10:18:00 GMT 2016


As pointed out by Manu in BZ.

Bootstrapped and tested on x86_64-unknown-linux-gnu, applied as obvious.

Richard.

2016-06-08  Richard Biener  <rguenther@suse.de>

	* c-common.c (parse_optimize_options): Improve diagnostic messages.

Index: gcc/c-family/c-common.c
===================================================================
--- gcc/c-family/c-common.c	(revision 237174)
+++ gcc/c-family/c-common.c	(working copy)
@@ -9542,10 +9542,10 @@ parse_optimize_options (tree args, bool
 		  ret = false;
 		  if (attr_p)
 		    warning (OPT_Wattributes,
-			     "bad option %s to optimize attribute", p);
+			     "bad option %qs to attribute %<optimize%>", p);
 		  else
 		    warning (OPT_Wpragmas,
-			     "bad option %s to pragma attribute", p);
+			     "bad option %qs to pragma %<optimize%>", p);
 		  continue;
 		}
 
@@ -9589,11 +9589,11 @@ parse_optimize_options (tree args, bool
 	  ret = false;
 	  if (attr_p)
 	    warning (OPT_Wattributes,
-		     "bad option %s to optimize attribute",
+		     "bad option %qs to attribute %<optimize%>",
 		     decoded_options[i].orig_option_with_args_text);
 	  else
 	    warning (OPT_Wpragmas,
-		     "bad option %s to pragma attribute",
+		     "bad option %qs to pragma %<optimize%>",
 		     decoded_options[i].orig_option_with_args_text);
 	  continue;
 	}



More information about the Gcc-patches mailing list