[PATCH] Consider functions with xloc.file == NULL (PR, gcov-profile/69028)

[Martin Liška]

On 07/21/2016 10:56 AM, Richard Biener wrote:
> On Wed, Jul 20, 2016 at 3:34 PM, Martin Liška <mliska@suse.cz> wrote:
>> Hi.
>>
>> Following patch addresses ICE which happens when coverage.c computes checksum
>> of a function w/o xloc.file. My patch assumes it's a valid state having a function
>> w/o xloc.file, which is situation exposed by cilkplus functions.
>>
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Ready to be installed?
> 
> Yes.
> 
> I think we should try to do better when assigning a location to new
> function decls,
> that is, avoid UNKNOWN_LOCATION and at least have some file information.
> For cilk-plus functions using the decl location of the original
> function might work.
> 
> That said, a safe-guard against this case is ok, thus the patch is as well.
> 
> Richard.

Thanks for review, I'm testing v2 where I copy SOURCE_LOCATION from the current_function_decl.

I'll install the patch after patch testing will pass.

M.

> 
>> Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Consider-functions-with-xloc.file-NULL-PR-gcov-profi-v2.patch
Type: text/x-patch
Size: 3072 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20160722/c2a082e1/attachment.bin>