[PATCH] Consider functions with xloc.file == NULL (PR, gcov-profile/69028)

Richard Biener richard.guenther@gmail.com
Thu Jul 21 08:56:00 GMT 2016


On Wed, Jul 20, 2016 at 3:34 PM, Martin Liška <mliska@suse.cz> wrote:
> Hi.
>
> Following patch addresses ICE which happens when coverage.c computes checksum
> of a function w/o xloc.file. My patch assumes it's a valid state having a function
> w/o xloc.file, which is situation exposed by cilkplus functions.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?

Yes.

I think we should try to do better when assigning a location to new
function decls,
that is, avoid UNKNOWN_LOCATION and at least have some file information.
For cilk-plus functions using the decl location of the original
function might work.

That said, a safe-guard against this case is ok, thus the patch is as well.

Richard.

> Martin



More information about the Gcc-patches mailing list