[PATCH 1/4] Make SRA scalarize constant-pool loads

Jeff Law law@redhat.com
Wed Jan 27 23:36:00 GMT 2016


On 01/27/2016 12:39 PM, David Edelsohn wrote:
> The new sra-17.c and sra-18.c tests fail on AIX because the regex is
> too restrictive -- AIX labels don't have exactly the same format.  On
> AIX, the labels in the dumps look like "LC..0" instead of ".LC0".
>
> This patch adds "*" and ".*" so that the "." prepended to LC is
> optional and to allow characters between the "LC" and the "0".
>
> I needed extra escapes for the sra-17.c line that matches multiple
> times - for no apparent reason.
The joys of expect/tcl.  I just keep escaping until the regex that I 
developed outside the suite works.  I have been trying to get away from 
using .* though.  The longest match nature sometimes gives surprising 
results.  In theory .*? ought to work better, but I haven't tried using 
it much.

Anyway, the change looks fine to me.

jeff



More information about the Gcc-patches mailing list