[PATCH] PR other/69006: fix extra newlines after diagnostics (v2)

Bernd Schmidt bschmidt@redhat.com
Tue Jan 26 11:18:00 GMT 2016


On 01/25/2016 09:13 PM, David Malcolm wrote:
> Here's an updated version of the patch.

Thanks!

> Instead of testing one particular kind of output via a plugin,
> this version of the patch adds code to gcc-dg-prune to issue a
> FAIL for any testcase containing blank lines, with a new
>    dg-allow-blank-lines-in-output
> directive for those test cases that legimitately emit blank lines.
> Examples of the latter include a test using -ftime-report, another
> using -fdump-tree-cunrolli-details=stderr, and a Fortran test
> using -fdump-fortran-original.

Is the =stderr test really necessary, or does it somehow predate the 
ability to scan dumps?

> OK for trunk in stage 4?  I regard PR 69006 as a regression, and it
> affects all diagnostics we output (unless caret-printing is
> disabled).

Yes, I think so. Ok.

> +  for (int row = layout.get_first_line ();
> +       row <= last_line;
> +       row++)

While you're fixing the layout here, see if that doesn't all fit on one 
line.


Bernd



More information about the Gcc-patches mailing list