[PATCH] c/68966 - atomic_fetch_* on atomic_bool not diagnosed

[Martin Sebor]

On 01/07/2016 05:07 AM, Marek Polacek wrote:
> On Wed, Jan 06, 2016 at 04:38:20PM -0700, Martin Sebor wrote:
>>>> gcc/testsuite/ChangeLog:
>>>> 2016-01-04  Martin Sebor  <msebor@redhat.com>
>>>>
>>>> 	PR c/68966
>>>> 	* gcc.dg/atomic-fetch-bool.c: New test.
>>>> 	* gcc.dg/sync-fetch-bool.c: Same.
>>>
>>> So the tradition is to repeat "New test." rather than to say "Same."
>>
>> Can we try not to make the rules any more rigid than they need
>> to be?  As we just discussed, following the required formatting
>> rules is error-prone and time-consuming enough.  GCC's own
>> Coding Conventions doesn't even require ChangeLog entries for
>> new tests (https://gcc.gnu.org/codingconventions.html#ChangeLogs).
>> People have been adding them and that's just fine with me, but
>> I can't discern any established convention when it comes to the
>> comment when a new test is being added.  I see examples of "New
>> test" or "New file" followed by "Likewise" or "Ditto" as well
>> as "New test" followed by "Same". I see no point in adding yet
>> another hoop for people to have to remember to jump through.
>
> Sorry, I didn't mean to nitpick; I just thought it's something worth
> pointing out, mostly for the future.

No problem.  It's easy enough to automate so I've modified my
ChangeLog script to print "New test." for each newly added test.
(I can't promise to use it consistently, though :)

Martin