Fix PR66208

Jeff Law law@redhat.com
Thu Jan 7 16:51:00 GMT 2016


On 01/07/2016 05:19 AM, Bernd Schmidt wrote:
> On 12/16/2015 11:14 PM, Jeff Law wrote:
>> On 12/16/2015 10:13 AM, Bernd Schmidt wrote:
>>> This is a relatively straightforward PR where we should mention a macro
>>> expansion in a warning message. The patch below implements the
>>> suggestion by Marek to pass a location down from
>>> build_function_call_vec. Ok if tests pass on x86_64-linux?
>
> Ping.
OK for the trunk.

>
>>> One question I have is about -Wformat, which is dealt with in the same
>>> area. We do get a mention of the macro expansion, but in a different
>>> style:
> [...]
>>> Is this what we're looking for in terms of output?
>
>> Are you referring to the "in definition" vs "in expansion" difference?
>> That appears to be a difference in the locus of the first displayed
>> diagnostic before the unwinding of the macros.
>
> Yeah. I just wanted to point it out in case anyone sees something wrong
> with this.
It's a bit arbitrary, but I think it's an artifact of input_locations, 
so I think it's OK for now.
jeff



More information about the Gcc-patches mailing list