[PATCH] libiberty: {count,dup,write}argv: constify argv input slightly

Ian Lance Taylor iant@google.com
Tue Jan 5 15:32:00 GMT 2016


On Sat, Jan 2, 2016 at 10:39 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> Would be more useful if we could use "const char * const *", but there's
> a long standing bug where gcc warns about incompatible pointers when you
> try to pass in "char **".

That's not a bug.  It's how C works.  http://c-faq.com/ansi/constmismatch.html

> We can at least constify the array itself as
> gcc will not warn in that case.
>
> include/:
> 2016-01-03  Mike Frysinger  <vapier@gentoo.org>
>
>         * libiberty.h (dupargv): Change arg to char * const *.
>         (writeargv, countargv): Likewise.
>
> libiberty/:
> 2016-01-03  Mike Frysinger  <vapier@gentoo.org>
>
>         * argv.c (dupargv): Change arg to char * const *.  Update comment.
>         (writeargv, countargv): Likewise.
>         * functions.texi (dupargv, writeargv, countargv): Likewise.

This is OK if it bootstraps.  Thanks.

Ian



More information about the Gcc-patches mailing list