[ping] Enable -mstackrealign with SSE on 32-bit Windows

Eric Botcazou ebotcazou@adacore.com
Sun Feb 28 14:37:00 GMT 2016


> No idea.  To me it sounds that -mincoming-stack-boundary=2 would allow to do
> -mstackrealign in those functions where it is necessary rather than in all.

That's not my reading of ix86_minimum_incoming_stack_boundary:

  /* Prefer the one specified at command line. */
  if (ix86_user_incoming_stack_boundary)
    incoming_stack_boundary = ix86_user_incoming_stack_boundary;
  /* In 32bit, use MIN_STACK_BOUNDARY for incoming stack boundary
     if -mstackrealign is used, it isn't used for sibcall check and
     estimated stack alignment is 128bit.  */
  else if (!sibcall
	   && ix86_force_align_arg_pointer
	   && crtl->stack_alignment_estimated == 128)
    incoming_stack_boundary = MIN_STACK_BOUNDARY;
  else
    incoming_stack_boundary = ix86_default_incoming_stack_boundary;

> If it was fixed for Solaris 9 that way I suppose it's ok for 32-bit
> Windows as well.
> 
> So consider the patch approved,

Thanks, now applied.  I presume I need to add a blurb to changes.html.

-- 
Eric Botcazou



More information about the Gcc-patches mailing list