[PATCH][CilkPlus] Fix PR69363
Markus Trippelsdorf
markus@trippelsdorf.de
Wed Feb 17 15:34:00 GMT 2016
On 2016.02.17 at 18:29 +0300, Ilya Verbin wrote:
> On Wed, Feb 17, 2016 at 16:28:34 +0100, Marek Polacek wrote:
> > On Wed, Feb 17, 2016 at 04:14:22PM +0100, Jakub Jelinek wrote:
> > > On Wed, Feb 17, 2016 at 04:11:44PM +0100, Marek Polacek wrote:
> > > > On Wed, Feb 17, 2016 at 06:08:14PM +0300, Ilya Verbin wrote:
> > > > > > This line is too long. But you could have just done
> > > > >
> > > > > My editor shows exactly 80 chars.
> > > >
> > > > The maximum is 79.
> > >
> > > Well, check_GNU_style.sh complains just about one line, and then
> > > a prototype.
> > >
> > > Lines should not exceed 80 characters.
> > > 193:+extern tree finish_omp_clauses (tree, bool, bool = false, bool = false);
> > > 252:+ error ("linear clause applied to non-integral non-pointer "
> >
> > Maybe it should be fixed with this then. Because
> > <https://www.gnu.org/prep/standards/standards.html#Formatting> says
> > "Please keep the length of source lines to 79 characters or less, for maximum
> > readability in the widest range of environments."
>
> https://gcc.gnu.org/codingconventions.html#Line says 80.
gcc % cat contrib/clang-format | grep ColumnLimit
ColumnLimit: 80
--
Markus
More information about the Gcc-patches
mailing list